This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, doc] Fix typos in documentation


I sent this out a couple of weeks ago, but it seems it never arrived on
the list.  So I guess Ping^0 and full-quote.  OK for trunk?

Kai, if you can confirm that this is semantically correct, then I can
just commit it as obvious on the doc-ness part of the patch.

Thanks,
Ralf

* Ralf Wildenhues wrote on Mon, Mar 01, 2010 at 08:36:18PM CET:
> Hi Kai,
> 
> * Kai Tietz wrote on Mon, Mar 01, 2010 at 09:32:46AM CET:
> > Ralf Wildenhues wrote on 28.02.2010 10:31:17:
> > > Further, I found one other issue, unfixed: extend.texi(Function
> > > Attributes) contains an unfinished sentence:
> > > | + Note, This feature is currently sorried out for Windows targets trying to
> > > 
> > > added by <http://gcc.gnu.org/viewcvs?view=revision&revision=136311>.
> > > Kai, what are these targets trying to?
> > 
> > Thanks for catching this. Well, the sentence should be completed as 
> > "disable -maccumulate-outgoing-args.".
> 
> Well, when I add that, I still can't parse the sentence, but that may be
> because I'm not a native speaker and have never heard the word "sorried".
> 
> Instead, how about this alternative formulation, which also removes the
> wrong capitalization.  Tested 'make info pdf html'.  Is the statement
> still correct?  OK for trunk?
> 
> Thanks,
> Ralf
> 
> Rewrite unfinished sentence in documentation.
> 
> gcc/ChangeLog:
> 2010-03-01  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
> 
> 	* doc/extend.texi (Function Attributes): Rewrite unfinished
> 	sentence in ms_abi documentation.
> 
> diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
> index f6b7158..1eadb02 100644
> --- a/gcc/doc/extend.texi
> +++ b/gcc/doc/extend.texi
> @@ -2708,7 +2708,8 @@ attribute tells the compiler to use the Microsoft ABI, while the
>  GNU/Linux and other systems.  The default is to use the Microsoft ABI
>  when targeting Windows.  On all other systems, the default is the AMD ABI.
>  
> -Note, This feature is currently sorried out for Windows targets trying to
> +Note, the @code{ms_abi} attribute for Windows targets currently requires
> +the @option{-maccumulate-outgoing-args} option.
>  
>  @item ms_hook_prologue
>  @cindex @code{ms_hook_prologue} attribute


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]