This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: r156315 - /trunk/config/mh-mingw
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: ktietz at gcc dot gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 14 Mar 2010 15:48:59 +0000 (UTC)
- Subject: Re: r156315 - /trunk/config/mh-mingw
- References: <20100128112602.5027.qmail@sourceware.org>
On Thu, 28 Jan 2010, ktietz@gcc.gnu.org wrote:
> Author: ktietz
> Date: Thu Jan 28 11:26:01 2010
> New Revision: 156315
>
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156315
> Log:
> Fix unnamed extension for ISO-C.
>
> Modified:
> trunk/config/mh-mingw
I cannot find any sign of this patch having been posted to the mailing
lists - all patches must be posted with proper rationale. It is also
missing a ChangeLog entry and has not been committed to the src
repository. Furthermore, it causes a regression for MinGW host (any
target); tools no longer build using a MinGW compiler that doesn't know
the -Wno-pedantic-ms-format option. In view of this regression, I propose
that we revert the patch. The proper place to add -Wno-pedantic-ms-format
is the same place as -Wall or -Wformat is added, in each directory's own
warning option logic and with a configure check for whether the option is
supported.
Index: config/mh-mingw
===================================================================
--- config/mh-mingw (revision 156314)
+++ config/mh-mingw (revision 156315)
@@ -1,6 +1,6 @@
# Add -D__USE_MINGW_ACCESS to enable the built compiler to work on Windows
# Vista (see PR33281 for details).
BOOT_CFLAGS += -D__USE_MINGW_ACCESS -Wno-pedantic-ms-format
-CFLAGS += -D__USE_MINGW_ACCESS
+CFLAGS += -D__USE_MINGW_ACCESS -Wno-pedantic-ms-format
# Increase stack limit to same as Linux default.
-LDFLAGS += -Wl,--stack,8388608
+LDFLAGS += -Wl,--stack,8388608 -Wl,-no-undefined
--
Joseph S. Myers
joseph@codesourcery.com