This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR42859
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Andrey Belevantsev <abel at ispras dot ru>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>
- Date: Wed, 10 Mar 2010 11:28:55 +0100
- Subject: Re: [PATCH] PR42859
- References: <4B975AF3.5000102@ispras.ru>
2010/3/10 Andrey Belevantsev <abel@ispras.ru>:
> Hello,
>
> As explained in the PR, the patch just filters out duplicate case labels in
> lower_eh_dispatch, removes unneeded edges, and finally removes unreachable
> blocks if some edges were really removed. ?I have no idea whether there is a
> better place to do this.
>
> The nested try construct in the test is needed to show that it's not enough
> to remove a single unreachable block. ?The hunk to Makefile.in adding the
> pointer-set.h dependency to tree-eh.o is missing because the dependency is
> already there :)
>
> Bootstrapped and regtested fine on x86-64 linux, ok for trunk?
Ok.
Thanks for fixing this!
Richard.
> Andrey
>
> 2010-03-10 ?Andrey Belevantsev ?<abel@ispras.ru>
>
> ? ? ? ?PR middle-end/42859
>
> ? ? ? ?* tree-eh.c: Include pointer-set.h.
> ? ? ? ?(lower_eh_dispatch): Filter out duplicate case labels and
> ? ? ? ?remove the unneeded edge when the label is unused. ?Return
> ? ? ? ?true when some edges are removed.
> ? ? ? ?(execute_lower_eh_dispatch): When any lowering resulted in
> ? ? ? ?removing an edge, also delete unreachable blocks.
>
>
> 2010-03-10 ?Andrey Belevantsev ?<abel@ispras.ru>
>
> ? ? ? ?* g++.dg/eh/pr42859.C: New test.
>