This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Reguire __cxa_atexit for ext/{new, throw}_allocator/deallocate_global.cc
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 24 Feb 2010 16:59:51 +0100
- Subject: Re: PATCH: Reguire __cxa_atexit for ext/{new, throw}_allocator/deallocate_global.cc
- References: <yddtyt6ln07.fsf@CeBiTec.Uni-Bielefeld.DE> <4B853C02.5000204@oracle.com> <4B854F49.5050104@gmail.com>
Hi Dave,
> Shouldn't this be xfailed on solaris, rather than skipped on all
> non-cxa_atexit targets?
>
> The FAIL in this case is indicating an ABI violation w.r.t order of dtors,
> which could equally happen on non-cxa_atexit systems that implement some
> variant scheme (such as e.g. get_exit_frame_monitor hooks!) and it seems
> useful to me if the testsuite flags that up, regardless of the internal
> implementation details of how the system handles (or, in this case, fails to
> handle correctly) finalisation.
>
given your observation about the hook itself, I tend to agree. If I
remember correctly, other systems should be also xfailed, eg, AIX
(xfailing is a bit tedious, isn't it?) I would also suggest Rainer to
add a couple of lines of comment summarizing this exchange here.
Paolo.