This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: move flag_debug_compare out of diagnostics.c
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Manuel LÃpez-IbÃÃez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- Date: Fri, 19 Feb 2010 19:20:36 -0200
- Subject: Re: move flag_debug_compare out of diagnostics.c
- References: <6c33472e1002191117w729a9f62mf6fbbda731a9845e@mail.gmail.com>
On Feb 19, 2010, Manuel LÃpez-IbÃÃez <lopezibanez@gmail.com> wrote:
> The uncommented test for flag_debug_compare in diagnostics.c is
> probably a left-over from the vta merge.
Nope, it's necessary to avoid issuing duplicate DT_NOTEs during
-fcompare-debug (two-stage) compilations.
Warnings are silenced by other means (gcc.c adds -w), and errors prevent
the second stage, so notes are the only the required special handling.
Silencing all diagnostics is kind of nice, but what if there's a
compiler bug that causes only the second stage to fail with an ICE, or
even a regular error? It would be nice if it wasn't silenced.
All that said, I don't object to the change, if that's the way people
want to go.
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer