This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Consistently generate widening multiplies
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Bernd Schmidt <bernds_cb1 at t-online dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Dorit Naishlos <DORIT at il dot ibm dot com>
- Date: Wed, 17 Feb 2010 00:18:15 +0100
- Subject: Re: Patch: Consistently generate widening multiplies
- References: <4B7B2373.9050305@t-online.de>
On Wed, Feb 17, 2010 at 12:00 AM, Bernd Schmidt <bernds_cb1@t-online.de> wrote:
> Tree-SSA introduced a regression with widening multiplications;
> extension operations are often separated from the MULT_EXPR they feed.
> There has been a patch last year to address this in expand_expr_real_2,
> but it's still rather more miss than hit as shown by the testcases
> included in the patch below.
Could this be http://gcc.gnu.org/PR29274 ? Would be a reason to push
the patch for gcc 4.5.
> This patch adds a new mini-pass to tree-ssa-math-opts.c.
*sigh* another mini-pass. There are a handful of them now, and they
all cost a full traversal of the function for very local, very special
pattern matching things (bswap, etc.) They should be grouped somehow
:-( I suppose there is no way to fold this into one of the existing
passes?
> +static unsigned int
> +execute_optimize_widening_mul (void)
(...)
> + ? ? ? ? ? ? if (rhs1_code != CONVERT_EXPR && rhs1_code != NOP_EXPR)
> + ? ? ? ? ? ? ? continue;
if (CONVERT_EXPR_CODE_P (rhs1_code)
Ciao!
Steven