This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, objc] fix PR43061
On Tue, Feb 16, 2010 at 1:36 AM, Mike Stump <mikestump@comcast.net> wrote:
> On Feb 15, 2010, at 4:05 PM, IainS wrote:
>>
>> proposed patch to fix this.
>> boostrapped/make check-objc ?on i686-apple-darwin9
>> restores the objc test results to the same as 156187 (last local set I
>> have).
>>
>> cheers
>> Iain
>>
>> 2010-02-15 ?Iain Sandoe ?<iain.sandoe@sandoe-acoustics.co.uk>
>>
>> ? ? ? ?PR objc/43061
>>
>> ? ? ? ?*gcc/objc/objc-act.c(finish_var_decl) ? Add "used" attribute to
>> ? ? ? ?vars in addition to the TREE_USED. This is needed by ipa*.c
>> ? ? ? ?and cgraphunit.c.
>
> So, it would seem to me that slightly better than this would be to have
> those places test DECL_PRESERVED_P.
Indeed.
Richard.
> ?If that fixes this, I think I like that
> version a bit better than this version. ?I'm fine with this going in now, if
> you want, though, would be nice to remove it once the rest of the compiler
> can handle it.
>