This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Fix PR42854 so weak linking works again on darwin
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, mikestump at comcast dot net, jakub at gcc dot gnu dot org
- Date: Sun, 14 Feb 2010 11:00:20 +0100
- Subject: Re: [PATCH]: Fix PR42854 so weak linking works again on darwin
- References: <20100214020809.GA3809@bromo.med.uc.edu>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, Feb 13, 2010 at 09:08:09PM -0500, Jack Howarth wrote:
> 2010-02-13 Jack Howarth <howarth@bromo.med.uc.edu>
>
> PR 42854
> * gcc/varasm.c: (declare_weak): Don't add weak attribute to
> decl if OBJECT_FORMAT_MACHO.
> (assemble_external): Don't restrict adding decls those with weak
> attribute if OBJECT_FORMAT_MACHO.
This is a wrong. IMNSHO you want to drop the lookup_attribute (, "weak")
tests in code related to weak_import inside of the darwin backend, instead
of this gross hack.
Jakub