This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Don't use # comments in inline asm (PR testsuite/41522)


On Mon, Jan 25, 2010 at 2:56 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
>
>> On Mon, Jan 25, 2010 at 02:47:29PM +0100, Rainer Orth wrote:
>>> Jakub Jelinek <jakub@redhat.com> writes:
>>>
>>> >> Hmm, ISTR issues when you are not actually using inputs/outputs
>>> >> in the asm text. ?Can you instead dg-skip your target?
>>>
>>> Sure could.
>>>
>>> > Or make the test { dg-do compile } instead of the default { dg-do assemble }
>>> > in this directory?
>>>
>>> Seems like the better option. ?I've searched in vain for the runtest
>>> invokation to check that change on its own, so I'm rerunning make
>>> check-gcc right now.
>>
>> That would be make check-gcc RUNTESTFLAGS=compile.exp=pr38*.c
>
> That worked. ?I'd instead tried with various relative and absolute
> pathnames to compile.exp instead of just the basename. ?The patch below
> was checked this way on sparc-sun-solaris2.10 and passes for 32 and 64
> bit.
>
> Ok for mainline?

Ok.

Thanks,
Richard.

> ? ? ? ?Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2010-01-25 ?Rainer Orth ?<ro@CeBiTec.Uni-Bielefeld.DE>
>
> ? ? ? ?PR testsuite/41522
> ? ? ? ?* gcc.c-torture/compile/pr38789.c: Change to dg-do compile.
> diff -r 580de06034a2 gcc/testsuite/gcc.c-torture/compile/pr38789.c
> --- a/gcc/testsuite/gcc.c-torture/compile/pr38789.c ? ? Wed Jan 20 14:17:00 2010 +0000
> +++ b/gcc/testsuite/gcc.c-torture/compile/pr38789.c ? ? Mon Jan 25 14:55:11 2010 +0100
> @@ -1,4 +1,5 @@
> ?/* PR tree-optimization/38789 */
> +/* { dg-do compile } */
>
> ?void
> ?baz (int v)
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]