Re: [PATCH: PR target/42671] Use Thumb1 GOT address loading sequence for Thumb2

[Carrot Wei <carrot at google dot com>]

Hi Richard

Could you help to review it?

thanks
Guozhi

On Sat, Jan 16, 2010 at 1:19 PM, Carrot Wei <carrot@google.com> wrote:
> After several days try, I successfully setup the testing with a qemu emulator.
>
> Now the compiler is configured with options --with-arch=armv7-a
> --target=arm-unknown-linux-gnueabi and glibc is used. -mthumb is also
> provided for dejagnu. There is still no new failure with my patch.
>
> thanks
> Guozhi
>
> On Tue, Jan 12, 2010 at 6:14 PM, Ramana Radhakrishnan
> <ramana.radhakrishnan@arm.com> wrote:
>>
>>> This patch was applied to trunk GCC and tested on the arm emulator with newlib.
>>> No new failure.
>>
>> I have no rights to approve or reject this patch but a couple of points
>> were not explicit in your mail.
>>
>> Did you specifically test for Thumb2 by configuring your compiler with
>> --with-arch=armv7-a and with -mthumb as a dejagnu variant ?
>>
>> Also I'm not sure how much execution testing you get with shared
>> libraries in the GNU torture tests. So maybe you want to include
>> arm-linux-gnueabi and eglibc as a part of some of this testing for
>> sanity checking ? I
>>
>>
>> Cheers
>> Ramana
>>
>>>
>>> ChangeLog:
>>> 2010-01-12 ?Wei Guozhi ?<carrot@google.com>
>>>
>>> ? ? ? ? PR target/42671
>>> ? ? ? ? * config/arm/arm.c (arm_load_pic_register): Change the Thumb2 code
>>> ? ? ? ? sequence as Thumb1.
>>> ? ? ? ? * config/arm/arm.md: Change "TARGET_THUMB1" to "TARGET_THUMB".
>>>
>>>
>>> thanks
>>> Guozhi
>>>
>>>
>>> Index: arm.c
>>> ===================================================================
>>> --- arm.c ? ? ? (revision 155799)
>>> +++ arm.c ? ? ? (working copy)
>>> @@ -5150,8 +5150,7 @@ arm_load_pic_register (unsigned long sav
>>> ? ? ? ? ? ? }
>>>
>>> ? ? ? ? ? emit_insn (gen_pic_load_addr_thumb2 (pic_reg, pic_rtx));
>>> - ? ? ? ? emit_insn (gen_pic_load_dot_plus_four (pic_tmp, labelno));
>>> - ? ? ? ? emit_insn (gen_addsi3 (pic_reg, pic_reg, pic_tmp));
>>> + ? ? ? ? emit_insn (gen_pic_add_dot_plus_four (pic_reg, pic_reg, labelno));
>>> ? ? ? ? }
>>> ? ? ? ?else /* TARGET_THUMB1 */
>>> ? ? ? ? {
>>>
>>>
>>> Index: arm.md
>>> ===================================================================
>>> --- arm.md ? ? ?(revision 155799)
>>> +++ arm.md ? ? ?(working copy)
>>> @@ -5267,7 +5267,7 @@
>>> ? ? ? ? ? ? ? ? ? ? (const_int 4)
>>> ? ? ? ? ? ? ? ? ? ? (match_operand 2 "" "")]
>>> ? ? ? ? ? ? ? ? ? ?UNSPEC_PIC_BASE))]
>>> - ?"TARGET_THUMB1"
>>> + ?"TARGET_THUMB"
>>> ? ?"*
>>> ? ?(*targetm.asm_out.internal_label) (asm_out_file, \"LPIC\",
>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?INTVAL (operands[2]));
>>
>>
>