This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: hook doc patch (18/112): TARGET_PASS_BY_REFERENCE
Quoting "Joseph S. Myers" <joseph@codesourcery.com>:
You should change "__builtin_va_arg" to "@code{__builtin_va_arg}". This
is not approval for the patch-as-changed; I have not otherwise reviewed
it.
2010-01-15 Joern Rennecke <amylaar@spamcop.net>
* tm.texi (TARGET_PASS_BY_REFERENCE): Fix argument types.
Add information on when type / cum may be null.
Index: tm.texi
===================================================================
--- tm.texi (revision 155367)
+++ tm.texi (working copy)
@@ -4123,9 +4135,11 @@ register to be used by the caller for th
@code{FUNCTION_INCOMING_ARG}, for the called function.
@end deftypefn
-@deftypefn {Target Hook} bool TARGET_PASS_BY_REFERENCE (CUMULATIVE_ARGS *@var{cum}, enum machine_mode @var{mode}, tree @var{type}, bool @var{named})
+@deftypefn {Target Hook} bool TARGET_PASS_BY_REFERENCE (CUMULATIVE_ARGS *@var{cum}, enum machine_mode @var{mode}, const_tree @var{type}, bool @var{named})
This target hook should return @code{true} if an argument at the
-position indicated by @var{cum} should be passed by reference. This
+position indicated by @var{cum} should be passed by reference.
+@var{type} may be null if this is a libcall. @var{cum} may be null
+if this query is from @code{__builtin_va_arg}. This
predicate is queried after target independent reasons for being
passed by reference, such as @code{TREE_ADDRESSABLE (type)}.