Re: [RFA] PR c++/42634

[Jason Merrill <jason at redhat dot com>]

On 01/09/2010 02:53 PM, Dodji Seketeli wrote:
> The patch below calls count_non_default_template_args with the innermost
> args, but then I saw that in commit r149066
> count_non_default_template_args is called with the full set of args so
> I think I am missing something.
>
> Why calling this function with the innermost args would be bad?

Well, whether it is right to call it with only the innermost args or the 
full set of args depends on how the TI_TEMPLATE is set.  If it points to 
the partial instantiation, then we want the innermost args; if it points 
to the most general template, then we want the full args.  That choice 
seems to have changed between r149066 and now, which I vaguely remember. 
 So this change is correct.  But please also revert the change from 
r149066 to count_non_default_template_args, as we don't need to pull out 
the innermost args there if we're doing it in the caller.

Jason