Re: PATCH: libstdc++/include/profile bug fixes and cleanup

[Benjamin Kosnik <bkoz at redhat dot com>]

> All of the changes are either serious bug fixes, cleanup requested by
> maintainers or minor features agreed previously by maintainers.
> This is the last round of changes for the profile mode for 4.5.

Yay. Great to see this.

> 1. Fix bug: Initialization would possibly run more than once on
> multithreaded programs due to missing fence.
> Fix by using compare_and_swap to set the state.
> 
> 2. Fix bug: Reentrance guard mechanism was broken since
> http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00890.html.
> Fix guard logic.

Whoops, sorry about that. Might want to add a small check to the
testsuite (at at later date) to catch this in the future, since it is
important.

> 3. Fix bug: Compile time disabling of individual diagnostics was
> broken. After this patch, to enable all diagnostics except "vector to
> list": g++ -D_GLIBCXX_PROFILE -D_GLIBCXX_PROFILE_NO_VECTOR_TO_LIST

Great. Seems sane.
 
> 4. Cleanup: Drop support for hash_map and hash_set.
> Requested by library maintainer Paolo Carlini.
> http://gcc.gnu.org/ml/libstdc++/2010-01/msg00026.html
> 
> 5. Cleanup: Get rid of templates used only for inline linkage.
> Requested by library maintainer Benjamin Kosnik.
> http://gcc.gnu.org/ml/libstdc++/2009-12/msg00015.html
> Replaced with inline functions containing static members.
> See new macros _GLIBCXX_PROFILE_DEFINE_DATA
> and _GLIBCXX_PROFILE_DATA.

OK
 
> 6. Minor feature: Add support for setting decision weights in config
> file. Reviewed by maintainer Benjamin Kosnik.
> http://gcc.gnu.org/ml/libstdc++/2009-12/msg00015.html
> 
> 7. Minor features: Add two simple diagnostics.
> list_to_vector and list_to_slist were added.  list_to_set was dropped
> from previous patch.
> Reviewed by maintainer Benjamin Kosnik.
> http://gcc.gnu.org/ml/libstdc++/2009-12/msg00015.html
> 
> 8. Update docs.
> Requested by maintener Benjamin Kosnik.
> http://gcc.gnu.org/ml/libstdc++/2009-12/msg00015.html

Thanks.

This is OK to me! 

-benjamin