This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Xilinx MicroBlaze support - 4 of 4

From: Richard Henderson <rth at redhat dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: Michael Eager <eager at eagercon dot com>, gcc-patches at gcc dot gnu dot org
Date: Wed, 06 Jan 2010 13:25:38 -0800
Subject: Re: [PATCH] Xilinx MicroBlaze support - 4 of 4
References: <4B43F514.30406@eagercon.com> <Pine.LNX.4.64.1001061245480.28877@digraph.polyomino.org.uk>

On 01/06/2010 05:16 AM, Joseph S. Myers wrote:

On Tue, 5 Jan 2010, Michael Eager wrote:

+%{mno-xl-soft-mul: -DHAVE_HW_MUL}       	\
+%{mxl-multiply-high: -DHAVE_HW_MUL_HIGH}    	\
+%{mno-xl-soft-div: -DHAVE_HW_DIV}       	\
+%{mxl-barrel-shift: -DHAVE_HW_BSHIFT}   	\
+%{mxl-pattern-compare: -DHAVE_HW_PCMP}  	\
+%{mhard-float: -DHAVE_HW_FPU}           	\
+%{mxl-float-convert: -DHAVE_HW_FPU_CONVERT} \
+%{mxl-float-sqrt: -DHAVE_HW_FPU_SQRT}   \


It is inappropriate for -m options to define user-namespace macros
unconditionally; best not to define them at all.

And if you want some implementation-space macros for these, they should not be done with SPEC entries like this, but rather with TARGET_CPU_CPP_BUILTINS. See i386-c.c for an example.

r~

Follow-Ups:
- Re: [PATCH] Xilinx MicroBlaze support - 4 of 4
  - From: Michael Eager

References:
- [PATCH] Xilinx MicroBlaze support - 4 of 4
  - From: Michael Eager
- Re: [PATCH] Xilinx MicroBlaze support - 4 of 4
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]