This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: plugin event for C frontend trees

From: Brian Hackett <bhackett1024 at gmail dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sat, 19 Dec 2009 22:32:19 -0800
Subject: Re: plugin event for C frontend trees
References: <407016140912181503r22ff60ddu991d362a82a27a98@mail.gmail.com> <84fc9c000912181506t64683258w6addb6a3312e50c7@mail.gmail.com> <407016140912181914j609e8a3exc43f205a577f29e8@mail.gmail.com> <84fc9c000912190301n31b4feb3r6d9de5f1d40d0dcb@mail.gmail.com>

Hi, I ran the bootstrap and regression tests (make -k check) on i686
Linux, revision 155362 and got the same set of missed regressions both
with and without the patch below.  Regression results at the end of
this message; these are similar to recent runs on gcc-testresults.

Brian

On Sat, Dec 19, 2009 at 3:01 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> The patch is ok if it passes bootstrap & regtest.
>
> Thanks,
> Richard.
>
>> Brian
>>
>>
>> gcc/ChangeLog
>>
>> 2009-12-18 ?Brian Hackett ?<bhackett1024@gmail.com>
>>
>> ? ? ? ?* plugin.def: Rename pre-genericize event.
>> ? ? ? ?* plugin.c (register_callback, invoke_plugin_callbacks): Same.
>> ? ? ? ?* c-decl.c (finish_function): Invoke callbacks on above event.
>>
>> gcc/cp/ChangeLog
>>
>> 2009-12-18 ?Brian Hackett ?<bhackett1024@gmail.com>
>>
>> ? ? ? ?* decl.c (finish_function): Rename pre-genericize event.
>>
>>
>> Index: gcc/plugin.def
>> ===================================================================
>> --- gcc/plugin.def ? ? ?(revision 155348)
>> +++ gcc/plugin.def ? ? ?(working copy)
>> @@ -27,8 +27,8 @@ DEFEVENT (PLUGIN_FINISH_TYPE)
>> ?/* Useful for summary processing. ?*/
>> ?DEFEVENT (PLUGIN_FINISH_UNIT)
>>
>> -/* Allows to see low level AST in C++ FE. ?*/
>> -DEFEVENT (PLUGIN_CXX_CP_PRE_GENERICIZE)
>> +/* Allows to see low level AST in C and C++ frontends. */
>> +DEFEVENT (PLUGIN_PRE_GENERICIZE)
>>
>> ?/* Called before GCC exits. ?*/
>> ?DEFEVENT (PLUGIN_FINISH)
>> Index: gcc/cp/decl.c
>> ===================================================================
>> --- gcc/cp/decl.c ? ? ? (revision 155348)
>> +++ gcc/cp/decl.c ? ? ? (working copy)
>> @@ -12560,7 +12560,7 @@ finish_function (int flags)
>> ? if (!processing_template_decl)
>> ? ? {
>> ? ? ? struct language_function *f = DECL_SAVED_FUNCTION_DATA (fndecl);
>> - ? ? ?invoke_plugin_callbacks (PLUGIN_CXX_CP_PRE_GENERICIZE, fndecl);
>> + ? ? ?invoke_plugin_callbacks (PLUGIN_PRE_GENERICIZE, fndecl);
>> ? ? ? cp_genericize (fndecl);
>> ? ? ? /* Clear out the bits we don't need. ?*/
>> ? ? ? f->x_current_class_ptr = NULL;
>> Index: gcc/c-decl.c
>> ===================================================================
>> --- gcc/c-decl.c ? ? ? ?(revision 155348)
>> +++ gcc/c-decl.c ? ? ? ?(working copy)
>> @@ -8052,6 +8052,7 @@ finish_function (void)
>> ? ? {
>> ? ? ? if (!decl_function_context (fndecl))
>> ? ? ? ?{
>> + ? ? ? ? invoke_plugin_callbacks (PLUGIN_PRE_GENERICIZE, fndecl);
>> ? ? ? ? ?c_genericize (fndecl);
>>
>> ? ? ? ? ?/* ??? Objc emits functions after finalizing the compilation unit.
>> Index: gcc/plugin.c
>> ===================================================================
>> --- gcc/plugin.c ? ? ? ?(revision 155348)
>> +++ gcc/plugin.c ? ? ? ?(working copy)
>> @@ -402,7 +402,7 @@ register_callback (const char *plugin_na
>> ? ? ? case PLUGIN_FINISH_TYPE:
>> ? ? ? case PLUGIN_START_UNIT:
>> ? ? ? case PLUGIN_FINISH_UNIT:
>> - ? ? ?case PLUGIN_CXX_CP_PRE_GENERICIZE:
>> + ? ? ?case PLUGIN_PRE_GENERICIZE:
>> ? ? ? case PLUGIN_GGC_START:
>> ? ? ? case PLUGIN_GGC_MARKING:
>> ? ? ? case PLUGIN_GGC_END:
>> @@ -483,7 +483,7 @@ invoke_plugin_callbacks (int event, void
>> ? ? ? case PLUGIN_FINISH_TYPE:
>> ? ? ? case PLUGIN_START_UNIT:
>> ? ? ? case PLUGIN_FINISH_UNIT:
>> - ? ? ?case PLUGIN_CXX_CP_PRE_GENERICIZE:
>> + ? ? ?case PLUGIN_PRE_GENERICIZE:
>> ? ? ? case PLUGIN_ATTRIBUTES:
>> ? ? ? case PLUGIN_PRAGMAS:
>> ? ? ? case PLUGIN_FINISH:
>>
>

		=== gcc tests ===

Running target unix
XPASS: gcc.dg/Warray-bounds.c  (test for warnings, line 59)
XPASS: gcc.dg/Warray-bounds.c  (test for warnings, line 65)
XPASS: gcc.dg/Wunreachable-8.c  (test for bogus messages, line 7)
FAIL: gcc.dg/pr34668-1.c (internal compiler error)
FAIL: gcc.dg/pr34668-1.c (test for excess errors)
XPASS: gcc.dg/uninit-6.c uninitialized variable warning (test for
bogus messages, line 42)
XPASS: gcc.dg/guality/example.c  -O0  execution test
XPASS: gcc.dg/guality/inline-params.c  -O0  execution test
XPASS: gcc.dg/guality/inline-params.c  -O1  execution test
XPASS: gcc.dg/guality/inline-params.c  -O2  execution test
XPASS: gcc.dg/guality/inline-params.c  -O3 -fomit-frame-pointer  execution test
XPASS: gcc.dg/guality/inline-params.c  -O3 -g  execution test
XPASS: gcc.dg/guality/inline-params.c  -Os  execution test
XPASS: gcc.dg/guality/pr41353-1.c  -O0  line 28 j == 28 + 37
FAIL: gcc.dg/guality/pr41353-1.c  -O1  line 28 i1 == 2 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O1  line 28 i2 == 3 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O2  line 28 i1 == 2 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O2  line 28 i2 == 3 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O3 -fomit-frame-pointer  line 28 i1 == 2 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O3 -fomit-frame-pointer  line 28 i2 == 3 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O3 -g  line 28 i1 == 2 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -O3 -g  line 28 i2 == 3 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -Os  line 28 i1 == 2 * 37
FAIL: gcc.dg/guality/pr41353-1.c  -Os  line 28 i2 == 3 * 37
XPASS: gcc.dg/guality/pr41447-1.c  -O0  execution test
XPASS: gcc.dg/guality/pr41616-1.c  -O0  execution test
XPASS: gcc.dg/guality/pr41616-1.c  -O1  execution test
XPASS: gcc.dg/guality/pr41616-1.c  -O2  execution test
XPASS: gcc.dg/guality/pr41616-1.c  -Os  execution test
XPASS: gcc.dg/struct/wo_prof_array_through_pointer.c scan-ipa-dump
ipa_struct_reorg "Number of structures to transform is 1"

		=== gcc Summary ===

# of expected passes		60738
# of unexpected failures	12
# of unexpected successes	18
# of expected failures		195
# of unsupported tests		519

		=== g++ tests ===

Running target unix

		=== g++ Summary ===

# of expected passes		21641
# of expected failures		145
# of unresolved testcases	2
# of unsupported tests		112

		=== gfortran tests ===

Running target unix

		=== gfortran Summary ===

# of expected passes		33075
# of expected failures		22
# of unsupported tests		134

		=== objc tests ===

Running target unix

		=== objc Summary ===

# of expected passes		1875
# of expected failures		7
# of unsupported tests		24

		=== libstdc++ tests ===

Running target unix
FAIL: abi_check
XPASS: 26_numerics/headers/cmath/c99_classification_macros_c.cc (test
for excess errors)

		=== libstdc++ Summary ===

# of expected passes		6580
# of unexpected failures	1
# of unexpected successes	1
# of expected failures		90
# of unsupported tests		401

		=== libffi tests ===

Running target unix

		=== libffi Summary ===

# of expected passes		1609
# of expected failures		10
# of unsupported tests		15

		=== libjava tests ===

Running target unix

		=== libjava Summary ===

# of expected passes		2574

		=== libgomp tests ===

Running target unix

		=== libgomp Summary ===

# of expected passes		2426

Follow-Ups:
- Re: plugin event for C frontend trees
  - From: Rafael Espindola

References:
- plugin event for C frontend trees
  - From: Brian Hackett
- Re: plugin event for C frontend trees
  - From: Richard Guenther
- Re: plugin event for C frontend trees
  - From: Brian Hackett
- Re: plugin event for C frontend trees
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]