Re: [PATCH]: Minor tweek: scope reduction part 1

[Paolo Carlini <paolo dot carlini at oracle dot com>]

On 12/01/2009 11:45 AM, d binderman wrote:
> 2009-12-01  David Binderman <dcb314@hotmail.com>
>
>         * gcc/tree-flow-inline.h (op_iter_next_use): Reduce scope of use_p.
>         * gcc/tree-flow-inline.h (op_iter_next_def): Reduce scope of def_p.
>         * gcc/tree-flow-inline.h (delink_stmt_imm_use): Reduce scope of iter and use_p.
>         * gcc/alias.c (nonoverlapping_memrefs_p): Reduce scope of tem.
>         * gcc/bb-reorder.c (insert_section_boundary_note): Reduce scope of first_partition.
>         * gcc/bt-load.c (compute_defs_uses_and_gen): Reduce scope of i.
>         * gcc/bt-load.c (choose_btr): Reduce scope of i.
>         * gcc/builtins.c (apply_args_size): Reduce scope of align.
>         * gcc/builtins.c (apply_result_size): Reduce scope of align and regno.
>         * gcc/builtins.c (expand_builtin_signbit): Reduce scope of hi, lo and word.
>         * gcc/builtins.c (fold_builtin_call_array): Reduce scope of i.
>   
In case you didn't notice already basing on the actual ChangeLog entries
of your previous patches, the style you used above isn't correct: first,
since the ChangeLog file belongs to the gcc directory, you do not repeat
gcc/ in front, actually you normally svn diff from *inside* gcc if you
are touching only gcc; also, you do not repeat every time the file you
are touching if you are touching multiple functions. Just have a look to
the existing ChangeLog entries, anyway, plenty of examples.

Finally... I would strongly suggest starting the Copyright assignment
paperworks, at least it would be a requirement at this point for
libstdc++, which I co-maintain, maintainers of these parts of the
compiler proper may have different opinions...

Paolo.