This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH - set but not used round two
On Tue, Nov 24, 2009 at 3:39 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> On 11/24/2009 02:58 PM, Richard Guenther wrote:
>>> @@ -15721,11 +15719,10 @@ add_location_or_const_value_attribute
>>> - ? ? ?status = NOTE_VAR_LOCATION_STATUS (node->var_loc_note);
>>> + ? ? ?NOTE_VAR_LOCATION_STATUS (node->var_loc_note);
>>>
>>> This macro call is useless then too.
>>>
>>> Index: cfgrtl.c
>>> ===================================================================
>>> --- cfgrtl.c ? ?(revision 154493)
>>> +++ cfgrtl.c ? ?(working copy)
>>> @@ -1506,16 +1506,12 @@ commit_one_edge_insertion (edge e)
>>> ? ? ? ? ? ? ? && BB_PARTITION (e->src) == BB_COLD_PARTITION
>>> ? ? ? ? ? ? ? && !(e->flags & EDGE_CROSSING))
>>> ? ? ? ? ? ? {
>>> - ? ? ? ? ? ? rtx bb_note, cur_insn;
>>> + ? ? ? ? ? ? rtx cur_insn;
>>>
>>> - ? ? ? ? ? ? bb_note = NULL_RTX;
>>> ? ? ? ? ? ? ? for (cur_insn = BB_HEAD (bb); cur_insn != NEXT_INSN (BB_END (bb));
>>> ? ? ? ? ? ? ? ? ? ?cur_insn = NEXT_INSN (cur_insn))
>>> ? ? ? ? ? ? ? ? if (NOTE_INSN_BASIC_BLOCK_P (cur_insn))
>>> - ? ? ? ? ? ? ? ? {
>>> - ? ? ? ? ? ? ? ? ? bb_note = cur_insn;
>>> - ? ? ? ? ? ? ? ? ? break;
>>> - ? ? ? ? ? ? ? ? }
>>> + ? ? ? ? ? ? ? ? break;
>>>
>>> This whole loop is useless as cur_insn isn't used either afterwards.
>>>
>> Paolo, can you do a followup patch please?
>>
> This is what I just boostrapped, in testing now. Is it ok?
Ok.
Thanks,
Richard.
> Thanks,
> Paolo.
>
> //////////////////
>