This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR c++/40892] Fix maybe_warn_cpp0x i18n problems
On Wed, 18 Nov 2009, Paolo Bonzini wrote:
> >> I have made two candidate patches. One is to pass an enum
> > > to this function and the other is pass the complete diagnostic text to it.
> > > Which one is ok for trunk?
> >
> > The second -- the one with enums.
>
> Since you like the enum approach, what would you think of something like
> http://gcc.gnu.org/ml/gcc-patches/2002-06/msg01620.html ?
I agree with the preference for the enums, but would rather put in full
sentences for translation instead of using fragments each of which is used
in multiple places, unless something makes using full sentences
infeasible.
--
Joseph S. Myers
joseph@codesourcery.com