This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Libstdc++ as DLL on windows, alternative approach [was Re: cygwin patch review]
- From: Danny Smith <dansmister at gmail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: Benjamin Kosnik <bkoz at redhat dot com>, libstdc++ at gcc dot gnu dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>, "Aaron W. LaFramboise (GCC)" <aaronavay62 at aaronwl dot com>, Kai Tietz <ktietz70 at googlemail dot com>
- Date: Mon, 16 Nov 2009 16:23:42 +1300
- Subject: Re: Libstdc++ as DLL on windows, alternative approach [was Re: cygwin patch review]
- References: <20091019092452.2e271791@mcgee.artheist.org> <4AFC8EC3.10502@gmail.com>
On Fri, Nov 13, 2009 at 11:40 AM, Dave Korn wrote:
> Benjamin Kosnik wrote:
>> From older mail thread:
>
> ?Likewise. ?I had to take some time away from this to do other stuff, but
> I've gotten back to it this week.
>
>> No. There is already visibility markup on libstdc++ headers for this.
>> You can just put the attribute visibility bits on namespace std, and be
>> done with it.
>>
>> Here, from include/bits/c++config.h:
>>
>> # define _GLIBCXX_BEGIN_NAMESPACE(X) namespace X
>> _GLIBCXX_VISIBILITY_ATTR(default)
>
<snip>
>
> ? ? ? ?* libstdc++-v3/include/bits/c++config (_GLIBCXX_VISIBILITY_ATTR): On
> ? ? ? ?platforms that don't support visibility, allow them to declare a macro
> ? ? ? ?_GLIBCXX_PSEUDO_VISIBILITY that is applied in place of visibility.
>
I like the idea but the name _GLIBCXX_PSEUDO_VISIBILITY is a bit
strange to me (and probably others with psuedo-dyslexia).
Why not _GLIBCXX_TARGET_VISIBILITY_ATTR or (more generically)
_GLIBCXX_TARGET_ACCESSIBILITY_ATTR that defaults to
_GLIBCXX_VISIBILITY_ATTR.
Danny