Re: [PATCH, i386]: Fix PR 41900, call *%esp shouldn't be generated because of CPU errata

[Uros Bizjak <ubizjak at gmail dot com>]

On 11/13/2009 05:44 PM, Richard Henderson wrote:

> > But all new targets (newer than P3) can use %esp here without 
> > problems...
>
> I'm concerned with the extra code required to allow the compiler to 
> properly compile something that's absolutely silly.

OK, patch will be (partially) reverted.

2009-11-13  Uros Bizjak <ubizjak@gmail.com>

    PR target/41900
    (*call_pop_1, *call_1, *call_value_pop_1, *call_value_1): Use "lsm"
    as operand 1 constraint.
    * config/i386/predicates.md (call_insn_operand): Depend on
    index_register_operand to avoid %esp register.

2009-11-13  Uros Bizjak <ubizjak@gmail.com>

    Revert:
    2009-11-03  Uros Bizjak <ubizjak@gmail.com>

    PR target/41900
    * config/i386/i386.h (ix86_arch_indices) <X86_ARCH_CALL_ESP>: New.
    (TARGET_CALL_ESP): New define.
    * config/i386/i386.c (initial_ix86_tune_features): Initialize
    X86_ARCH_CALL_ESP.
    * config/i386/i386.md (*call_pop_1_esp, *call_1_esp,
    *call_value_pop_1_esp, *call_value_1_esp): Rename from *call_pop_1,
    *call_1, *call_value_pop_1 and *call_value_1.  Depend on
    TARGET_CALL_ESP.
    (*call_pop_1, *call_1, *call_value_pop_1, *call_value_1):
    New patterns, use "lsm" as operand 1 constraint.
    * config/i386/predicates.md (call_insn_operand): Depend on
    index_register_operand for !TARGET_CALL_ESP to avoid %esp register.

Thanks,
Uros.

Attachment: p.diff.txt
Description: Text document