Re: [PATCH] Fix MIPS LHX in mips-dsp.md

[David Daney <ddaney at caviumnetworks dot com>]

Richard Sandiford wrote:
> "Fu, Chao-Ying" <fu@mips.com> writes:
> > Though I don't think the original GCC tests will be affected by this patch,
> > I will re-run GCC tests.
>
> Thanks, that was all I was really asking about.  I should have been more
> specific, sorry.
>
> There's a general GCC rule that code patches must be regression-tested
> against the full GCC testsuite (or at least all the parts associated
> with the languages that your target supports by default).  The idea
> is to make sure that no existing tests start to fail after the patch.
> If you're confident they won't (and I agree they're unlikely to in
> this case), well, all the better!  It should just be a formality.

Several times I have created seemingly trivial patches where I was 
certain that there would be no regressions.  However, the step of 
running the testsuite for regressions uncovered some problems.  So I 
wouldn't classify it a a busy-work type formality, it is an important 
tool to help us improve quality.

David Daney