This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove some "set but not used" variables
- From: Ian Lance Taylor <iant at google dot com>
- To: d binderman <dcb314 at hotmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 08 Nov 2009 12:45:47 -0800
- Subject: Re: Remove some "set but not used" variables
- References: <BLU108-W240A7C2AA200B6585795C39CAE0@phx.gbl>
d binderman <dcb314@hotmail.com> writes:
> 2009-11-07Â David Binderman <dcb314@hotmail.com>
>
> ÂÂÂÂÂÂÂ * builtins.c (apply_args_size, expand_builtin_mathfn, expand_powi,
> ÂÂÂÂÂÂÂ expand_builtin_expect, maybe_emit_sprintf_chk_warning):
> ÂÂÂÂÂÂÂ Remove some set but not used variables.
> ÂÂÂÂÂÂÂ * calls.c (flags_from_decl_or_type): Same.
> ÂÂÂÂÂÂÂ * genautomata.c (check_regexp_units_distribution): Same.
The ChangeLog entry needs to mention the removal of
apply_args_reg_offset.
> --- gcc/builtins.c.sav 2009-11-06 19:32:09.000000000 +0000
> +++ gcc/builtins.c 2009-11-07 10:03:53.000000000 +0000
> @@ -1263,7 +1263,7 @@
> gives the offset of that register into the block returned by
> __builtin_apply_args. 0 indicates that the register is not
> used for calling a function. */
> -static int apply_args_reg_offset[FIRST_PSEUDO_REGISTER];
> +/* static int apply_args_reg_offset[FIRST_PSEUDO_REGISTER]; not used */
Please remove this variable and its comment, don't just comment it
out.
This is OK with that change.
Thanks.
Ian