This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix check_effective_target_xop
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "rajagopal, dwarak" <dwarak dot rajagopal at amd dot com>, Uros Bizjak <ubizjak at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>, "Harle, Christophe" <christophe dot harle at amd dot com>, "Jagasia, Harsha" <harsha dot jagasia at amd dot com>
- Date: Thu, 5 Nov 2009 15:29:17 +0100
- Subject: Re: [PATCH] Fix check_effective_target_xop
- References: <5787cf470910210254m63c9f5bbp2585eb4f52ab8360@mail.gmail.com> <1C8DE0332CB01445BF7ADEDE3DDD570718D0502C@sausexmbp02.amd.com> <4AE5DB24.7090907@gmail.com> <1C8DE0332CB01445BF7ADEDE3DDD5707191E68CC@sausexmbp02.amd.com> <20091105133600.GO14664@tyan-ft48-01.lab.bos.redhat.com> <20091105141454.GQ14664@tyan-ft48-01.lab.bos.redhat.com>
On Thu, Nov 5, 2009 at 3:14 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Nov 05, 2009 at 02:36:00PM +0100, Jakub Jelinek wrote:
>> On Thu, Oct 29, 2009 at 01:14:21PM -0500, rajagopal, dwarak wrote:
>> > As you suggested, I'll submit a separate patch to fix those issues.
>>
>> I've noticed that this check fails differently than I'd expect:
>> xop1265.c: In function '_mm_maccs_epi16':
>> xop1265.c:8:13: error: can't convert between vector values of different size
>> compiler exited with status 1
>>
>> instead of:
>>
>> /tmp/cc0fdl6g.s: Assembler messages:
>> /tmp/cc0fdl6g.s:9: Error: no such instruction: `vpmacssww %xmm2,%xmm0,%xmm1,%xmm0'
>> compiler exited with status 1
>>
>> (btw, when will be the XOP/LWP binutils support submitted?).
>>
>> The problem is that the test uses a non-existing builtin name.
>>
>> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
>> trunk?
>
> Richi suggests it is better to actually post the patch ;)
Ok. (I think this is obvious)
Thanks,
Richard.
> 2009-11-05 ?Jakub Jelinek ?<jakub@redhat.com>
>
> ? ? ? ?* gcc.target/i386/i386.exp (check_effective_target_xop): Fix typo
> ? ? ? ?in builtin's name.
>
> --- gcc/testsuite/gcc.target/i386/i386.exp.jj ? 2009-11-04 18:31:22.000000000 +0100
> +++ gcc/testsuite/gcc.target/i386/i386.exp ? ? ?2009-11-05 11:02:03.000000000 +0100
> @@ -153,9 +153,9 @@ proc check_effective_target_xop { } {
> ? ? ? ?typedef short __v8hi __attribute__ ((__vector_size__ (16)));
> ? ? ? ?__m128i _mm_maccs_epi16(__m128i __A, __m128i __B, __m128i __C)
> ? ? ? ?{
> - ? ? ? ? ? return (__m128i) __builtin_ia32_pmacssww ((__v8hi)__A,
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? (__v8hi)__B,
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? (__v8hi)__C);
> + ? ? ? ? ? return (__m128i) __builtin_ia32_vpmacssww ((__v8hi)__A,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?(__v8hi)__B,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?(__v8hi)__C);
> ? ? ? ?}
> ? ? } "-O2 -mxop" ]
> ?}
>
>
> ? ? ? ?Jakub
>