This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR 38867: unexpanded prefix in LIBGCJ_PREFIX

From: Andrew Haley <aph at redhat dot com>
To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
Date: Mon, 02 Nov 2009 09:38:58 +0000
Subject: Re: PR 38867: unexpanded prefix in LIBGCJ_PREFIX
References: <20091101113818.GC3737@gmx.de>

Ralf Wildenhues wrote:

When the user does not specify --prefix to configure, LIBGCJ_PREFIX
ends up containing the string "NONE", bogusly.  See the PR.  The patch
below fixes that, and a couple of other instances that might get that
string otherwise.

I don't see what breakage the NONE causes in the end for the user, so
I'm unsure about proper testing.  I remade configure-target-libjava,
with and without --prefix passed to toplevel configure, and checked the
result.  What other tests should I be doing?  Otherwise, OK for trunk?

Thanks,
Ralf

Work with defaulted $prefix (NONE) in libjava.

libjava/ChangeLog:
2009-11-01  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	PR bootstrap/38867
	* configure.ac (expanded_prefix): New variable, set to the
	default prefix if none was passed on the command line.
	* configure: Regenerate.

That looks OK.

Thanks,
Andrew.

References:
- PR 38867: unexpanded prefix in LIBGCJ_PREFIX
  - From: Ralf Wildenhues

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]