This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^4] Named address spaces: support multiple pointer modes
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: rth at redhat dot com (Richard Henderson)
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 26 Oct 2009 19:53:02 +0100 (CET)
- Subject: Re: [PING^4] Named address spaces: support multiple pointer modes
Richard Henderson wrote:
> On 10/23/2009 12:48 PM, Ulrich Weigand wrote:
> > the last patch required to enable named address space support is still unreviewed:
> > http://gcc.gnu.org/ml/gcc-patches/2009-10/msg00325.html
>
> > @@ -801,7 +807,8 @@ promote_mode (const_tree type ATTRIBUTE_
> > case REFERENCE_TYPE:
> > case POINTER_TYPE:
> > *punsignedp = POINTERS_EXTEND_UNSIGNED;
> > - return Pmode;
> > + return targetm.addr_space.address_mode
> > + (TREE_ADDR_SPACE (TREE_TYPE (type)));
>
> TYPE_ADDR_SPACE?
Fixed, thanks.
> > @@ -4315,7 +4323,7 @@ initializer_constant_valid_p (tree value
> > case POINTER_PLUS_EXPR:
> > case PLUS_EXPR:
> > if (! INTEGRAL_TYPE_P (endtype)
> > - || TYPE_PRECISION (endtype) >= POINTER_SIZE)
> > + || TYPE_PRECISION (endtype) >= TYPE_PRECISION (TREE_TYPE (value)))
>
> int_pointer_precision?
I've now changed this to read:
if (! INTEGRAL_TYPE_P (endtype)
|| TYPE_PRECISION (endtype)
>= int_or_pointer_precision (TREE_TYPE (value)))
> Otherwise it looks ok.
Many thanks for the review!
As all patches of the named address space patch set are now approved,
I'll commit the patch set shortly (after a final round of testing).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com