This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Don't use test with == in toplevel configure
Richard Guenther <richard.guenther@gmail.com> writes:
>> I've found another instance of such a construct in the same file:
>>
>> if test `cat cygwin-cat-check` == a ; then
>>
>> This is from config/acx.m4 (ACX_CHECK_CYGWIN_CAT_WORKS) and should
>> probably be fixed as well, although it doesn't trigger on non-Cygwin
>> hosts.
>>
>> Ok for mainline?
>
> I think this counts as obvious.
Thanks, installed. I suppose I can install the acx.m4 change under the
obvious rule as well, although I cannot test it? The config/acx.m4 is
obviously GCC specific and not imported from some upstream.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
2009-10-23 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
config:
* acx.m4 (ACX_CHECK_CYGWIN_CAT_WORKS): Use = with test.
toplevel:
* configure: Regenerate.
Index: config/acx.m4
===================================================================
--- config/acx.m4 (revision 153469)
+++ config/acx.m4 (working copy)
@@ -605,7 +605,7 @@
AC_DEFUN([ACX_CHECK_CYGWIN_CAT_WORKS],[
AC_MSG_CHECKING([to see if cat works as expected])
echo a >cygwin-cat-check
-if test `cat cygwin-cat-check` == a ; then
+if test `cat cygwin-cat-check` = a ; then
rm cygwin-cat-check
AC_MSG_RESULT(yes)
else