This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't fail on SS_ABS

From: Jie Zhang <jie dot zhang at analog dot com>
To: Bernd Schmidt <bernds_cb1 at t-online dot de>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 19 Oct 2009 16:34:04 +0800
Subject: Re: [PATCH] Don't fail on SS_ABS
References: <4AD849BA.9080406@analog.com> <4AD8ABAC.9010509@t-online.de>

Hi Bernd,

Bernd Schmidt wrote:

Jie Zhang wrote:

SS_ABS is not handled in simplify_const_unary_operation and ss_abs is
not documented. This patch fixes these. Is it OK for mainline?

+@code{ss_abs} ensures that an out-of-bounds result saturates to the
+maximum signed value.
+


Maybe clarify that as "maximum positive number representable as a signed
value"?  Otherwise ok.

But "maximum signed value" is the same meaning of "maximum positive number representable as a signed value", isn't? I prefer the former, which is simple and short. Is it OK if I commit the original patch?

Jie

Follow-Ups:
- Re: [PATCH] Don't fail on SS_ABS
  - From: Bernd Schmidt

References:
- [PATCH] Don't fail on SS_ABS
  - From: Jie Zhang
- Re: [PATCH] Don't fail on SS_ABS
  - From: Bernd Schmidt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]