This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Use LDPL_FATAL instead of assert

From: "Joseph S. Myers" <joseph at codesourcery dot com>
To: Cary Coutant <ccoutant at google dot com>
Cc: Rafael Espindola <espindola at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
Date: Fri, 16 Oct 2009 00:36:45 +0000 (UTC)
Subject: Re: [patch] Use LDPL_FATAL instead of assert
References: <38a0d8450910151133o563baec6qcd685a9ba1eceb70@mail.gmail.com> <c17be2b30910151453p32169188g2fda9fe6d2203e65@mail.gmail.com>

On Thu, 15 Oct 2009, Cary Coutant wrote:

> Other than Joseph's comment about message style (and provided it's OK
> to defer the I18N stuff), the rest looks good.

If you defer the i18n issues (which I leave up to the plugin maintainers), 
please file a PR for them and mark it as blocking PR 40883.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [patch] Use LDPL_FATAL instead of assert
  - From: Rafael Espindola
- Re: [patch] Use LDPL_FATAL instead of assert
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]