This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [h8300] Add dwarf2 debugging support

On 10/14/2009 03:21 PM, DJ Delorie wrote: 
I was thinking about the add/add/addx option - the only drawback is
that you may create an $sp that points beyond the end of the available
stack space, if the stack space is small.

True. I'd sort of ignored that, assuming the maximum of 254 extra stack used wasn't significant; if you're that low on stack is an interrupt likely to work anyway? I just hate the thought of using 10 adds to allocate 20 bytes of stack.

You should definitely attack this as a separate patch from the rest.

You might ask the customer whether the possible 254 bytes of extra stack is significant. If so, implement the push/mov/add/restore sequence; if not, implement the add/add/addx sequence.


r~

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]