Re: [PATCH] Fix builtin attributes on powerpc

[David Edelsohn <dje dot gcc at gmail dot com>]

On Thu, Oct 1, 2009 at 2:57 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> I tried to get this in by yesterday, but I had some server issues, and I
> couldn't get the tests run until today.
>
> In working with Jakub on a backport of the power7 patches to the Red Hat 4.4
> branch, we found some problems in running spec. ?The problem turned out to that
> the vectorized math functions had different declaration attributes than the
> scalar versions of the functions. ?In doing further investigation, it turned
> out that we weren't setting any attributes for any builtin functions. ?This
> patch fixes the attributes for the Altivec (VMX) and VSX builtins. ?I have not
> done the spe and paired builtins in this patch, but that can be easily done
> later.
>
> I did the usual boostrap and make check with no regressions.
>
> Is this acceptable to checkin under stage 3 as a backend change?

If this is the design that the community wants to use in all backends,
it is fine with me.

I think MAX_RS6000_BUILTINS is more consistent with the naming
convention in the rest of GCC than RS6000_BUILTIN_COUNT.

The patch is okay.

Thanks, David