This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fatal error when failing to register a new pass [eg from plugin]


Paolo Bonzini wrote:
On 10/13/2009 11:47 AM, Basile STARYNKEVITCH wrote:

I agree with your analysis, but I believe we should help plugin developers by telling them a bit more than just the uninformative message produced by gcc_unreachable.

I agree with you; while a gcc_unreachable would be more than fine in the core of GCC, when plugins are involved we should always lean towards informative error messages---especially if the patch is already written that way.



Is that an OK to commit my patch to trunk? http://gcc.gnu.org/ml/gcc-patches/2009-10/msg00809.html

Of course I can change "can%'t" to "can't" or "cannot" in the error message, or whatever peopla like.

Regards.

--
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]