This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][LTO] Re-set boolean_type_node in free_lang_data

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Diego Novillo <dnovillo at google dot com>
Date: Mon, 12 Oct 2009 12:30:17 +0200
Subject: Re: [PATCH][LTO] Re-set boolean_type_node in free_lang_data
References: <84fc9c000907101225w7a6b1cc1h19d2181c07303993@mail.gmail.com> <200910121200.10905.ebotcazou@adacore.com> <84fc9c000910120314i281310d6q24db47013ea2fc34@mail.gmail.com>

> It is done properly in lto1.

Then why doing it in non-LTO mode as well?

> Can you expand on why this will break Ada in subtle ways?  Note that after
> free_lang_data the frontend isn't involved in anything anymore.

This changes the precision of boolean_type_node, which is 8 in Ada with the 
corresponding TYPE_MAX_VALUE because of invalid values so that tests like

  if (x > 1)

are not optimized away.

-- 
Eric Botcazou

Follow-Ups:
- Re: [PATCH][LTO] Re-set boolean_type_node in free_lang_data
  - From: Richard Guenther

References:
- Re: [PATCH][LTO] Re-set boolean_type_node in free_lang_data
  - From: Eric Botcazou
- Re: [PATCH][LTO] Re-set boolean_type_node in free_lang_data
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]