This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR41217 Driver crashes if -o specified without filename
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: rmansfield at qnx dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 6 Oct 2009 11:33:43 +0200
- Subject: Re: [Patch] PR41217 Driver crashes if -o specified without filename
- References: <4A9D78FA.9020104@qnx.com> <4AAE4E7B.4080405@qnx.com> <84fc9c000909301308s5d252fe8kc0e4457a5b2d520d@mail.gmail.com> <4ACA4A3D.6050604@qnx.com>
On Mon, Oct 5, 2009 at 9:34 PM, Ryan Mansfield <rmansfield@qnx.com> wrote:
> Richard Guenther wrote:
>>
>> On Mon, Sep 14, 2009 at 4:08 PM, Ryan Mansfield <rmansfield@qnx.com>
>> wrote:
>>>
>>> Ryan Mansfield wrote:
>>>>
>>>> This patch fixes a crash if -o is specified without an argument.
>>>>
>>>> 2009-09-01 ?Ryan Mansfield ?<rmansfield@qnx.com>
>>>> ? ? ? PR driver/41217
>>>> ? ? ? * gcc.c (process_command): Check that -o argument was specified.
>>>>
>>>> Index: gcc.c
>>>> ===================================================================
>>>> --- gcc.c ? ? ? (revision 151276)
>>>> +++ gcc.c ? ? ? (working copy)
>>>> @@ -4161,7 +4161,10 @@
>>>> ? ? ? ? ? ? ? argv[i] = convert_filename (argv[i], ! have_c, 0);
>>>> ?#endif
>>>> ? ? ? ? ? ? /* Save the output name in case -save-temps=obj was used.
>>>> ?*/
>>>> - ? ? ? ? ? ? save_temps_prefix = xstrdup ((p[1] == 0) ? argv[i + 1] :
>>>> argv[i] + 1);
>>>> + ? ? ? ? ? ? if ((p[1] == 0) && ?argv[i + 1])
>>>> + ? ? ? ? ? ? ? save_temps_prefix = xstrdup(argv[i + 1]);
>>>> + ? ? ? ? ? ? ?else
>>>> + ? ? ? ? ? ? ? save_temps_prefix = xstrdup(argv[i] + 1);
>>>> ? ? ? ? ? ? goto normal_switch;
>>>>
>>>> ? ? ? ? ? default:
>>>
>>> Ping?
>>
>> Ok.
>>
>> Thanks,
>> Richard.
>
> Thanks. Could someone please apply the patch on my behalf?
Done, r152488.
Richard.