This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gengtype & plugins [#define emitted in wrong order]
Diego Novillo wrote:
On Sat, Oct 3, 2009 at 01:55, Basile STARYNKEVITCH
<basile@starynkevitch.net> wrote:
2009-10-01 Basile Starynkevitch <basile@starynkevitch.net>
* gengtype.c (write_types): Moved call to write_func_for_structure
into seperate loops.
With this change in the changelog, is the patch OK for trunk??
OK with those changes and testing that the generated files work.
gengtype works ok for the trunk, and the patch works for MELT as a
plugin (using the same gengtype in plugin mode).
A warm thanks to Diego for the review and the patience, and to Rafael
Espindola for the work.
I also added Rafael Espindola's name&email in the gcc/ChangeLog entry.
2009-10-05 Basile Starynkevitch <basile@starynkevitch.net>
Rafael Espindola <espindola@google.com>
* gengtype.c (write_types): Moved call to write_func_for_structure
into seperate loops.
I hope Rafael is not offended by being named here... (He did most of
gengtype improvement after my initial patch).
I am very happy to have committed that as revision 152455, because for
the very first time, MELT can be compiled as an ordinary GCC plugin
(previously, you had to use MELT's gengtype - which had this correction).
BTW, I tend to believe that gengtype might be installed somewhere
(perhaps as gcc-gengtype), and we could also want to put the version
string of GCC inside gengtype binary (or perhaps is it already there?).
We might also want to have gengtype accepting more a GNU way for program
arguments (probably at least have gengtype accepting --version & --help).
Regards.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***