This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][LTO] Re-write decl & cgraph merging
On Mon, Oct 5, 2009 at 07:34, Richard Guenther <rguenther@suse.de> wrote:
> Âvoid
> ! lto_symtab_merge_decls (void)
> Â{
> ! Â lto_symtab_maybe_init_hash_table ();
> ! Â htab_traverse (lto_symtab_identifiers, lto_symtab_merge_decls_1, NULL);
> Â}
Hmm, does it matter how we go about merging decls? It shouldn't,
but we are pointer hashing here.
> ! Â /* Mark cgraph nodes needed in the merged cgraph.
> ! Â Â Â??? ÂIs this really necessary? Â*/
> ! Â for (node = cgraph_nodes; node; node = node->next)
> ! Â Â if (cgraph_decide_is_function_needed (node, node->decl))
> ! Â Â Â cgraph_mark_needed_node (node);
I don't think it is, but better try it after this patch goes in.
Very nice cleanup. Thanks. This is OK to commit.
Diego.