This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gengtype & plugins [#define emitted in wrong order]
- From: Basile STARYNKEVITCH <basile at starynkevitch dot net>
- To: Gerald Pfeifer <gerald at pfeifer dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Rafael Espindola <espindola at google dot com>, Diego Novillo <dnovillo at google dot com>
- Date: Sat, 03 Oct 2009 07:55:02 +0200
- Subject: Re: gengtype & plugins [#define emitted in wrong order]
- References: <4AC3CBF5.9030008@starynkevitch.net> <4AC44702.7050508@starynkevitch.net> <alpine.LSU.1.99.0910022259040.899@acrux.dbai.tuwien.ac.at>
Gerald Pfeifer wrote:
On Thu, 1 Oct 2009, Basile STARYNKEVITCH wrote:
I am also attaching the gcc/ChangeLog entry
2009-10-01 Basile Starynkevitch <basile@starynkevitch.net>
* gengtype.c (write_types): Moved call to write_func_for_structure
into seperate loops to ensure that all the functions are emitted
after their declarations and #define-d macros.
The ChangeLog should only describe what changes, not whay. The latter
you may want to put as comments in the code.
Thanks for the comment. Hence, the gcc/ChangeLog should be simply:
2009-10-01 Basile Starynkevitch <basile@starynkevitch.net>
* gengtype.c (write_types): Moved call to write_func_for_structure
into seperate loops.
With this change in the changelog, is the patch OK for trunk??
Regards.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***