This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gengtype & plugins [#define emitted in wrong order]
- From: Rafael Espindola <espindola at google dot com>
- To: Basile STARYNKEVITCH <basile at starynkevitch dot net>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
- Date: Thu, 1 Oct 2009 15:51:57 -0400
- Subject: Re: gengtype & plugins [#define emitted in wrong order]
- References: <4AC3CBF5.9030008@starynkevitch.net> <4AC44702.7050508@starynkevitch.net>
> Correcting the problem is actually simple, as the attached patch (against
> trunk r152356) demonstrates. I just moved the write_func_for_structure calls
> inside write_types into their own loops.
>
> I am also attaching the gcc/ChangeLog entry
>
> Ok for trunk if it bootstraps?
The patch looks reasonable, what I don't understand is why this is a
problem only for plugins. Do you know what makes the old order work
for the non-plugin case?
Some comments:
* The } on line 2773 in unaligned.
* There is a trailing space on the "emit the functions" comment on line 2793.
* There is a dummy ; on line 2818
>
> Regards
>
> PS: I really hope this small kind of bugfix fits in stage 3. Should I make a
> bug report decribing http://gcc.gnu.org/ml/gcc-patches/2009-09/msg02274.html
> in bugzilla?
>
Cheers,
--
Rafael Ãvila de EspÃndola