This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [LTO merge][13/15] Add LTO front end


On Wed, 30 Sep 2009, Diego Novillo wrote:

> > The host portability issue with __attribute__ ((visibility ("hidden")))
> > has already been noted. ÂI suggest conditioning the attributes on defined
> > (__GNUC__) && defined (__ELF__) - GCC should support the attribute on ELF
> > hosts, but LTO should also work for ELF targets with non-ELF hosts.
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41526

You'll need to ensure there is some fix or workaround in place before the 
merge to trunk to avoid breaking the build.  (If the problem code is only 
included in the LTO front end, rather than in files built unconditionally 
such as the streamer, disabling LTO for affected hosts may be a temporary 
workaround to allow the code to merge.)

> >> +/* This needs to be included after config.h. ÂOtherwise, _GNU_SOURCE will not
> >> + Â be defined in time to set __USE_GNU in the system headers, and strsignal
> >> + Â will not be declared. Â*/
> >> +#include <sys/mman.h>
> >
> > mmap and <sys/mman.h> are also not portable to all supported hosts (e.g.
> > MinGW). ÂThere should be configure tests and a suitable fallback.
> 
> Added to PR41526.

Likewise.

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]