This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Avoid using NETBSD_CC1_AND_CC1PLUS_SPEC in vax-netbsd target when it is not defined
- From: Krister Walfridsson <krister dot walfridsson at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: thorpej at netbsd dot org, matt at 3am-software dot com, gcc-patches at gcc dot gnu dot org
- Date: Sun, 27 Sep 2009 22:58:57 +0200
- Subject: Re: RFA: Avoid using NETBSD_CC1_AND_CC1PLUS_SPEC in vax-netbsd target when it is not defined
- References: <m3iqf717u2.fsf@redhat.com>
On Fri, Sep 25, 2009 at 3:18 PM, Nick Clifton <nickc@redhat.com> wrote:
> ?I am not sure where NETBSD_CC1_AND_CC1PLUS_SPEC is supposed to be
> ?defined, but it is simple enough to avoid using it when it is not.
> ?The patch below does this and allows gcc to be built.
>
> ?Is this patch OK, or is there a better way to solve the problem ?
The NETBSD_CC1_AND_CC1PLUS_SPEC is added in config/netbsd.h in the
NetBSD repository to pass a NetBSD-specific -cxx-isystem to
cc1/cc1plusplus. My preference would be just to remove the usage in
the vax configuration for now. It can be re-added if the mechanism is
contributed. (But I guess Matt has the last say as the vax
maintainer...)
> +#ifdef NETBSD_CC1_AND_CC1PLUS_SPEC
> ?#undef CC1_SPEC
> ?#define CC1_SPEC NETBSD_CC1_AND_CC1PLUS_SPEC VAX_CC1_AND_CC1PLUS_SPEC
>
> #undef CC1PLUS_SPEC
> ?#define CC1PLUS_SPEC NETBSD_CC1_AND_CC1PLUS_SPEC VAX_CC1_AND_CC1PLUS_SPEC
> +#endif
I think this should be
#undef CC1_SPEC
#define CC1_SPEC VAX_CC1_AND_CC1PLUS_SPEC
#undef CC1PLUS_SPEC
#define CC1PLUS_SPEC VAX_CC1_AND_CC1PLUS_SPEC
when !defined(NETBSD_CC1_AND_CC1PLUS_SPEC)
/Krister