This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] dg-final { gdb-test { .. } } support (take 2)
On Mon, 2009-09-21 at 17:23 +0200, Jakub Jelinek wrote:
> On Mon, Sep 21, 2009 at 10:19:17AM -0400, Daniel Jacobowitz wrote:
> > On Mon, Sep 21, 2009 at 03:00:03PM +0200, Jakub Jelinek wrote:
> > > > > + set fd [open "| $gdb_name -nw -nx -quiet -x $cmd_file ./$output_file 2>/dev/null" r]
> > > >
> > > > Start GDB with "remote_spawn host" rather than a local pipe, then interact
> > > > with remote_expect etc..
> > >
> > > host? This is target...
> > > The previous patch had ![is_remote target] condition, so
> > > remote_spawn/remote_expect wasn't IMHO needed, but I've changed it anyway.
> >
> > This seems to be - for now, at least - native only. But I think we
> > still don't want to run GDB on the target; it is conceptually a host
> > tool.
> >
> > Also, isnative is a target triplet check. Isn't [is_remote target]
> > needed if we use "run"?
>
> All I care about is native testing, I don't have any experience with remote
> testing. I can just re-add ![is_remote target] check back and leave the
> remote testing to those who care about it.
This looks good to me.
Janis