This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][libstdc++-v3 parallel mode] Uglification of internal identifiers
> > Change begin* to __begin*.
>
> Where?
As data in the (otherwise abbreviated) ChangeLog entry. Just list the
transformations into something like this.
Ie:
2009-09-10 Johannes Singler <singler@ira.uka.de>
* include/parallel/*: Uglify internal identifiers as follows.
Change begin* to __begin*. Change x to y. Change z to b.
etc.
Maybe this is too much information, anyway, and you can get away with:
2009-09-10 Johannes Singler <singler@ira.uka.de>
* include/parallel/*: Uglify internal identifiers.
Much less work. Don't care myself. Unless you hear objections just go
with the latter.
> > Also, as a side note, for this code:
> >
> > + template<typename _Iterator1, typename _Iterator2, typename
> > _Iterator3,
> > + typename _IteratorCategory>
> > + class _IteratorTriple
> > {
> > private:
> > - typedef iterator_triple<Iterator1, Iterator2, Iterator3,
> > - IteratorCategory> type;
> > + typedef _IteratorTriple<_Iterator1, _Iterator2, _Iterator3,
> > + _IteratorCategory> _Self;
> >
> > _Self is redundant with just _IteratorTriple. Is this just a style
> > thing?
>
> You are right, _Self is redundant. But I would like to fix that
> later.
Sure. This is what I meant with "stages" above: just start on the
cleanups and do a couple of passes. You don't have to get it 100% the
first time.
best,
-benjamin