This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][libstdc++-v3 parallel mode] Fix memory leaks in multiway_merge
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Johannes Singler <singler at ira dot uka dot de>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 11 Sep 2009 17:16:23 +0200
- Subject: Re: [PATCH][libstdc++-v3 parallel mode] Fix memory leaks in multiway_merge
- References: <4AA8C9DF.2040703@ira.uka.de> <4AA9285F.6080203@oracle.com> <4AAA5F56.6000107@ira.uka.de>
Hi,
>> I'm trusting you both about the issue proper and the fix.
>>
> Sorry, I don't understand this phrase grammatically.
>
Ok, my english isn't the best in the world, but what's so strange about
it? I meant: I'm not going to use valgrind or other proprietary tools in
order to verify myself that there is currently a leak (you didn't
provide a way to reproduce it) and that your patch actually fixes it:
since the issue seems simple, I'm just going to trust after a quick
check by inspection. Better now?
> Somehow, this blank line sneaked in. Better like this? Or still add
> some colon?
>
Isn't a big issue, of course. By the way, I said <semicolon>, not <colon>.
Paolo.