This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [vta->trunk] VTA merge
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org, jakub at redhat dot com
- Date: Thu, 03 Sep 2009 04:07:41 -0300
- Subject: Re: [vta->trunk] VTA merge
- References: <orskfb6zb2.fsf@huru.localdomain> <84fc9c000908300345s473a12f5u1b25ba054ca5f9a1@mail.gmail.com> <or7hwk9xxy.fsf@huru.localdomain> <84fc9c000908310230n3cbfc13bn1f83fcc6e0e688e9@mail.gmail.com> <ork50j8vks.fsf@huru.localdomain> <b609cb3b0909010816s56852dd1n76787aa0387a73d9@mail.gmail.com> <ormy5eikul.fsf@huru.localdomain>
On Sep 1, 2009, Alexandre Oliva <aoliva@redhat.com> wrote:
> Here's the patch I intend to check in tonight.
In a last-minute (ok, make that last couple of hours ;-) review of the
patch, I realized tree-ssa-loop-ivopts.c was working too hard, dropping
uses of an SSA DEF early, instead of letting them be propagated into
debug stmts by the later-introduced code in release_ssa_name.
This patch reverts that (hopefully) unnecessary change. Ok to install,
if it passes regression testing?
for gcc/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* tree-ssa-loop-ivopts.c (remove_unused_ivs): Let release_ssa_name
propagate removed DEFs into debug uses.
Index: gcc/tree-ssa-loop-ivopts.c
===================================================================
--- gcc/tree-ssa-loop-ivopts.c.orig 2009-09-01 23:40:27.000000000 -0300
+++ gcc/tree-ssa-loop-ivopts.c 2009-09-03 03:02:45.000000000 -0300
@@ -5622,24 +5622,7 @@ remove_unused_ivs (struct ivopts_data *d
&& !info->inv_id
&& !info->iv->have_use_for
&& !info->preserve_biv)
- {
- if (MAY_HAVE_DEBUG_STMTS)
- {
- gimple stmt;
- imm_use_iterator iter;
-
- FOR_EACH_IMM_USE_STMT (stmt, iter, info->iv->ssa_name)
- {
- if (!gimple_debug_bind_p (stmt))
- continue;
-
- /* ??? We can probably do better than this. */
- gimple_debug_bind_reset_value (stmt);
- update_stmt (stmt);
- }
- }
- remove_statement (SSA_NAME_DEF_STMT (info->iv->ssa_name), true);
- }
+ remove_statement (SSA_NAME_DEF_STMT (info->iv->ssa_name), true);
}
}
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer