This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] New function for checking misalignment
On Wed, Sep 2, 2009 at 9:21 PM, Revital1 Eres<ERES@il.ibm.com> wrote:
> Hello,
>
>> > This patch adds a new target hook for checking if unaligned access
>> > with a certain misalignment factor is supported by the target.
>> >
>> > Tested on powerpc64 and x86.
>> > OK for mainline? Comments are welcome.
>>
>> The bool parameter to the targethook needs documenting. ?In fact
>> it sounds redundant - the misalignment parameter should be enough
>> here, no? ?And yes, the hook needs documenting in doc/tm.texi.
>
> I think that if the misalignment is unknown we need to have the packed
> field in order to determine whether it can be supported.
> I'll fix the rest of the comments and post a new version.
Hm. But if the access is packed then TYPE_ALIGN_UNIT on the type
should be 1.
Richard.