This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3] Fix race condition in libstdc++-v3/configure.ac


On 09/01/2009 10:49 PM, Ralf Wildenhues wrote:
* Paolo Bonzini wrote on Tue, Sep 01, 2009 at 10:06:06AM CEST:
On 08/31/2009 11:26 PM, Ralf Wildenhues wrote:
I wasn't quite sure whether the 'cd include&&   make' is necessary each
time include/Makefile is changed, or only when config.status is invoked
without arguments (i.e., after configure runs).  The patch assumes the
latter and introduces a 'generate-headers' tag for this.

It seems safest to invoke "make -C include pch_build=" on every include/Makefile change, and leave the pch to be created by the recursive make invocation. In principle, the task of include/Makefile could be done all by AC_CONFIG_LINKS, but not pch creation.

So you are saying that the fact that the precompiled headers are created early is by accident, not intentional?

I understood PCH are used only to speed up the testsuite and "fgrep -lr stdc++.h ." seems to confirm this.


> That's why the patch below is broken.

Bummer. Let's leave it in generate-headers, it cannot be worse than what was before. The previous version is okay then, with or without pch_build=.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]