This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [vta->trunk] VTA merge


On Tue, 1 Sep 2009, Alexandre Oliva wrote:

> > (along with various other Unixisms 
> > in the testcase that may not even work on all supported native systems), 
> 
> Now that's surprising to me.  What is it that you're referring to?

sys/wait.h, used in guality.h, does not exist for MinGW, which is a 
supported native system on the list of secondary platforms for 4.5.  "> 
/dev/null 2>&1" is Unix syntax; the null device is NUL on Windows.  Some 
other things I thought would be Unixisms (such as getpid) do seem to be 
present on MinGW after all, though I don't know about any other non-Unix 
native systems GCC may support (VMS?).

> > you need to make guality.exp not try to run any tests for non-native
> > testing,
> 
> Sorry, I was pretty sure I'd already done that, but it's obvious I
> haven't.  This is bad.  I'll prepare a follow up patch to address this,
> and post it for approval before I install the merge patch.

Note that DejaGnu's "isnative" is not the right thing here, since that 
tests whether build == target, and what's relevant in this case is whether 
host == target (I see no reason the existing tests should not work for 
testing the case build != host == target).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]