This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch libcpp]: Issue about st_size comparison
2009/8/31 Dave Korn <dave.korn.cygwin@googlemail.com>:
> Kai Tietz wrote:
>
>>> The issue is that gcc is clever enough to detect that a comparison of
>>> long > long long (max), can never be true. So it emits a warnings. As
>>> libcpp uses -Werrror - as you surely know - build fails.
>
> ?Oh yes. ?Silly me.
>
>> ? ? ? ?* files.c (read_file_guts): Remove check for _WIN64 target, as check is
>> ? ? ? ?always zero and leads to failure for Stage 2 build of libgcc for target.
>
> ?That looks like a cleaner fix. ?I wondered if there were #defines for the
> maximum values of off_t and ssize_t that we could use to make a more generic
> test, but it's not terribly important.
>
> ? ?cheers,
> ? ? ?DaveK
>
>
well for off_t there aren't, and AFAIK for ssize_t there aren't, too.
But this thing could be handled also in configure test to check if
sizeof(off_t) > sizeof (ssize_t). Because just in this case the
complete check makes sense here.
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination