This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/5] Named address spaces: C front-end support
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 26 Aug 2009 16:52:31 +0000 (UTC)
- Subject: Re: [PATCH 3/5] Named address spaces: C front-end support
- References: <200908260750.n7Q7oAht015283@d12av02.megacenter.de.ibm.com>
On Wed, 26 Aug 2009, Ulrich Weigand wrote:
> + /* Warn about address space used for things other that static memory or
"other that" should be "other than".
> + else if (decl_context == PARM && TREE_CODE (type) != ARRAY_TYPE)
> + error ("%qs specified for parameter %qE",
> + c_addr_space_name (address_space), name);
> + else if (decl_context == FIELD)
> + error ("%qs specified for structure field %qE",
> + c_addr_space_name (address_space), name);
What happens with unnamed parameters or bit-fields (so name is NULL)
declared with an address space qualifier? If they can reach here then you
need to allow for that case with a different diagnostic text, and you
should make sure there are testcases for this in the testsuite.
I don't see any other issues with this patch version.
--
Joseph S. Myers
joseph@codesourcery.com