This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^2] Re: [PING/tiny respin] Re: [PATCH, 0...4/4] Enable libstdc++ as a DLL on windows platforms.
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Mon, 10 Aug 2009 20:24:19 +0100
- Subject: Re: [PING^2] Re: [PING/tiny respin] Re: [PATCH, 0...4/4] Enable libstdc++ as a DLL on windows platforms.
- References: <4A60F7BA.3040204@gmail.com> <4A6FCDB1.4050504@gmail.com> <4A7F29A7.9010508@gmail.com>
2009/8/9 Dave Korn:
>
> ?Ping; part of this patch is still awaiting review by a v3 maintainer, and the
> clock is starting to tick on stage 1, so I've remembered to Cc the v3 list this
> time.
I can't approve or reject, but have some questions. As a v3
developer, how do I avoid breaking cygwin in future, without having to
learn how DLLs work? e.g. I would have guessed the manipulators
ends/endl in include/bits/ostream.tcc would also be marked with
_GLIBCXX_IMPORT, but they're not. If I add new code, can I ignore
_GLIBCXX_IMPORT and rely on a cygwin maintainer to fix any breakage?
Looks like you've made some lines >80 characters, that goes against
the C++STYLE standard.
Jonathan