This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix wrong code for push of long double
- From: Mikulas Patocka <mikulas at artax dot karlin dot mff dot cuni dot cz>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 6 Aug 2009 05:09:21 +0200 (CEST)
- Subject: Re: [PATCH] fix wrong code for push of long double
- References: <4A78742F.4020106@gmail.com>
Hi
> Can you please try if attached patch fixes your problem? (I'm currently
> testing this patch on x86_64-pc-linux-gnu {,-m32}).
I tried your patch, it works, it's just more clean than my.
> This test belongs to gcc.target/i386. Add "dg-require-effective-target ilp32",
> since it is valid only on x86_32.
>
> This test is not valid on x86_64, so it should be limited to ilp32 targets.
> Usually, __attribute__((noinline)) is used instead of -fno-inline.
My tests are valid on all architectures, they contain portable code (is
there any arch without long double?). On other architectures they don't
test any known bug, but they could be run anyway to protect the bug from
reappearing. I don't see why you want to run them only on i386.
On x86-64 it just warns that -mpush-args doesn't work with unwind tables
(what are unwind tables good for if I don't use C++?), but you could just
disable -mpush-args, not the whole test.
Mikulas
> Thanks,
> Uros.
>
>